Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: review team for Python Requirements Upgrade job #91

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: review team for Python Requirements Upgrade job #91

merged 1 commit into from
Nov 1, 2024

Conversation

nadeemshahzad
Copy link
Member

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@nadeemshahzad nadeemshahzad merged commit 098cf61 into master Nov 1, 2024
3 checks passed
@nadeemshahzad nadeemshahzad deleted the nadeem/fix_team_name branch November 1, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhanumar farhanumar farhanumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadeemshahzad @farhanumar